Feature/47 visualize latest pitest report #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 3, 2023 00:43
…eport Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
…owFactory and fixed the other files for the pre-commit Signed-off-by: nikomall34 <[email protected]>
… so I removed unnecessary code. Adjusted the displayed names Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
Signed-off-by: nikomall34 <[email protected]>
…m:amosproj/amos2023ws02-pitest-ide-plugin into Feature/47-Visualize-Latest-Pitest-Report
Signed-off-by: nikomall34 <[email protected]>
lheimbs
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Generally looks good, just some notes (maybe stuff to work on in a future sprint):
- Use Font/Colors/... from user settings in intellij
- No need to assign people, assignment means working on it. Just requesting a review is enough :)
- Use
git rebaseto apply new changes from main instead ofgit mergeto avoid merge commits on your own branch
.../src/main/kotlin/com/amos/pitmutationmate/pitmutationmate/visualization/CustomProgressBar.kt
Show resolved
Hide resolved
When clicking on an entry, maybe deactivate the possibility to be editable, as when double clicking on the individual cells, I can destroy the UI as seen in the Screenshot
|
Signed-off-by: nikomall34 <[email protected]>
|
Now you shouldn't be able to edit the cells anymore. Thanks for pointing that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ToolWindow in the Tab "Latest Result" you can see the latest pitest result.
I tried to keep the original pitest layout as good as possible.